This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] [2/5] Types reference counting [garbage-collector]
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 25 May 2009 10:17:15 +0200
- Subject: Re: [patch] [2/5] Types reference counting [garbage-collector]
- References: <20090411102127.GC32624@host0.dyn.jankratochvil.net> <m3hc0ocmcw.fsf@fleche.redhat.com>
On Thu, 16 Apr 2009 23:36:15 +0200, Tom Tromey wrote:
> Jan> +/* Unify type_group of all the type structures found while crawling the
> Jan> + type_group_link_table tree from the starting point type. DATA contains
> Jan> + type_group_link reference of the starting point type. Only during the first
>
> I think both of these should read "starting point TYPE", since they
> are referring to the value of the variable "type".
I really meant they did refer to a general English term type (represented in
GDB by `struct type'). But thanks for the proofreading and updated the text.
> We don't check that TYPE is reclaimable here, but it seems like we
> could. This isn't very important to me, but I thought I'd see what
> you think.
+ The reclaimability is not assertion checked here as it means an
+ expensive type_group_link_table lookup for each MAIN_TYPE being deleted. */
Thanks,
Jan