This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Fix "break foo" when `foo's prologue ends before line table


> > > +  /* Linetable entries are ordered by PC values, see the commentary in
> >                                                             ^^^^^^ comment
> 
> Hmm? are you saying that "commentary" is incorrect English?  If so, I
> beg to differ. ;-)

It seems to me that "commentary" would be used in a different context,
not to refer to some text describing what a piece of code does.  But
I'm not a native English speaker, so I might be wrong.

> Is the comment I added before the call to skip_prologue_using_lineinfo
> good enough?

It looks great to me :)

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]