Re: [RFA] Fix too many "no debugging symbols found" warnings.

[Eli Zaretskii <eliz at gnu dot org>]

> Date: Sat, 23 May 2009 16:24:14 -0700 (PDT)
> From: dje@google.com (Doug Evans)
> 
> We'd like to avoid adding any new option.
> And I'd like to avoid ports having to specify what system libraries are.
> That may be ultimately useful, but it seems excessive for the task at hand.
> OTOH, "set print symbol-loading off|on" is new for 7.0, so we could
> replace it with something else if that's TRTTD.
> 
> The high-order bit of what needs to be done here is to be able
> to turn off the warnings for shared-libs.  And since
> "set print symbol-loading off|on" is new for 7.0 ...
> 
> I propose the following:
> 
> 1) rename "set print symbol-loading" to "set print solib-symbol-loading"
> 2) always print such messages for the main executable

There's also a possibility to make this a tristate option instead of a
simple boolean one.  After all, it's quite possible that development
snapshots of GDB were available on several GNU/Linux distros for some
time, and so the argument of "new in GDB 7.0" is not necessarily
strong enough.

> --- NEWS	18 May 2009 13:25:33 -0000	1.312
> +++ NEWS	23 May 2009 22:36:12 -0000
> @@ -193,9 +193,10 @@ set sh calling-convention
>  show sh calling-convention
>    Control the calling convention used when calling SH target functions.
>  
> -set print symbol-loading
> -show print symbol-loading
> -  Control printing of symbol loading messages.
> +set print solib-symbol-loading
> +show print solib-symbol-loading
> +  Control printing of messages when loading symbols from shared object
> +  libraries.

This is okay.

> @@ -4175,9 +4197,9 @@ the global debug-file directory prepende
>  				     &setlist, &showlist);
>  
>    add_setshow_boolean_cmd ("symbol-loading", no_class,
> -                           &print_symbol_loading, _("\
> -Set printing of symbol loading messages."), _("\
> -Show printing of symbol loading messages."), NULL,
> +                           &print_solib_symbol_loading, _("\
> +Set printing of symbol loading messages for shared object libraries."), _("\
> +Show printing of symbol loading messages for shared object libraries."), NULL,

This seem to leave the option's name unaltered, unlike your
explanations and unlike the docs changes.  Or am I missing something?

> --- doc/gdb.texinfo	15 May 2009 16:53:45 -0000	1.593
> +++ doc/gdb.texinfo	23 May 2009 22:36:13 -0000

This part is approved, assuming we agree to the code change and the
removal of the previous functionality,. and also subject to a couple
of comments:

> +@cindex print messages when shared object library symbols are loaded

This index entry is too long.  Suggest to shorten it like this:

  @cindex announce loading symbols from shared libraries

I would also add another one:

  @cindex shared libraries, announce loading symbols

> +The @code{set print solib-symbol-loading} command allows you to enable or

"This command" is shorter and doesn't lose any information, since the
name of the command is clearly visible at this spot.

Thanks.