This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA]: handle_extended_wait: Call linux_resume_one_lwp instead of ptrace
- From: Pedro Alves <pedro at codesourcery dot com>
- To: gdb-patches at sourceware dot org
- Cc: Doug Evans <dje at google dot com>
- Date: Sun, 24 May 2009 18:00:42 +0100
- Subject: Re: [RFA]: handle_extended_wait: Call linux_resume_one_lwp instead of ptrace
- References: <20090524031422.C486F846C2@localhost>
On Sunday 24 May 2009 04:14:22, Doug Evans wrote:
> There are some things that linux_resume_one_lwp does that either
> all callers of ptrace (PTRACE_CONT) should do (check errno)
> or would be nice to do (print a debugging message).
> I was thinking of splitting linux_resume_one_lwp into two,
> but since the newly created thread is, well, new the rest of
> linux_resume_one_lwp is a nop; so it seems reasonable to just call
> linux_resume_one_lwp for the new thread.
> It's also nice to have all calls to ptrace (PTRACE_CONT)
> routed through one function.
Agreed. It doesn't look like there are extra syscalls and
it's all O(1) in that fast path.
>
> Ok to check in?
> [tested on amd64 w/ --target_board=native-gdbserver, no regressions]
>
> 2009-05-23 Doug Evans <dje@google.com>
>
> * linux-low.c (handle_extended_wait): Use linux_resume_one_lwp
> to resume the newly created thread, don't call ptrace (PTRACE_CONT)
> directly.
Ok.
--
Pedro Alves