This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Prec/RFA] Remove macros for record size in i386-linux-tdep.c


On Saturday 23 May 2009 05:00:22, Hui Zhu wrote:
> 2009-05-23 ?Hui Zhu ?<teawater@gmail.com>
> 
> ????????* i386-linux-tdep.c (I386_LINUX_RECORD_SIZE_*,
> ????????I386_LINUX_RECORD_IOCTL_*,
> ????????I386_LINUX_RECORD_FCNTL_*) Removed.
> ????????(i386_linux_init_abi): Change size of record from macros to
> ????????numbers.

Okay.

> ????????* i386-linux-tdep.c (i386_linux_init_abi): Change
> ????????i386_linux_record_tdep.size_char from 8 to 1.

You didn't mention this, so I take it it was going to be a separate patch.
Why do you need size_char at all?  size of char is always 1 by definition.
Does the kernel define this as variable somewhere also?

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]