This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA/Windows] Remove ADD_SHARED_SYMBOL_FILES macro
- From: Christopher Faylor <cgf-use-the-mailinglist-please at sourceware dot org>
- To: gdb-patches at sourceware dot org, Joel Brobecker <brobecker at adacore dot com>, Pierre Muller <muller at ics dot u-strasbg dot fr>
- Date: Fri, 22 May 2009 13:10:05 -0400
- Subject: Re: [RFA/Windows] Remove ADD_SHARED_SYMBOL_FILES macro
- References: <003d01c9d4e2$987399a0$c95acce0$@u-strasbg.fr> <20090522153042.GB23016@adacore.com>
Thanks for relabelling the subject so that I'd notice it.
On Fri, May 22, 2009 at 08:30:42AM -0700, Joel Brobecker wrote:
>> 2009-05-15 Pierre Muller <muller@ics.u-strasbg.fr>
>>
>> * symfile.c (add_shared_symbol_files_command): Remove
>> prototype and function.
>> (_initialize _symfile): Move "add-shared-symbol-files"
>> command and "assf" alias.
>
>This part is fine.
>
>> * windows-nat.c (_initialize_windows_nat): to here.
>
>This part, however, is unnecessary, I think. There is already a command
>called dll-symbols that calls the very same function (dll_symbol_command).
>My suggestion would be to delete the add-shared-symbols-files entirely,
>or to make it a deprecated alias to dll-symbols.
>
>Chris, what do you think?
I don't know enough about how other people use this command. I use
dll-symbols all of the time (for one specific dll which shall go
unamed). I don't know if people are using other commands instead so I
don't think it can be deleted. Making it an alias makes sense, though.
With that change, I'm fine with checking this in.
cgf