This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Fix printing frame arguments for COFF debug info
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 20 May 2009 14:32:00 -0700
- Subject: Re: [RFA] Fix printing frame arguments for COFF debug info
- References: <83d4a9q9e5.fsf@gnu.org>
> The first step towards solving this is to fix coffread.c, as in the
> patch I suggest below. OK to commit it?
> 2009-05-16 Eli Zaretskii <eliz@gnu.org>
>
> * coffread.c (process_coff_symbol): Set the symbol's language to
> the language of current_subfile.
That seems like a sensible change, and it is something we also do
in the stabs reader, so I'd say this is OK.
> Even if this patch is accepted, I'm not sure that's all we need to do.
> At least minsyms.c:prim_record_minimal_symbol_and_info also sets the
> symbol's language to language_auto. Should we make sure neither
> common_val_print nor val_print ever get language_auto as the language?
> That is, should we fall back to current_language in that case?
I see that this is addressed in one of your followup messages, so
I'll send my take on it there.
--
Joel