This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Fix DW_AT_const_value using DW_FORM_string
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org, Sami Wagiaalla <swagiaal at redhat dot com>, Michael Matz <matz at suse dot de>, archer at sourceware dot org, Richard Guenther <rguenther at suse dot de>
- Date: Wed, 20 May 2009 13:51:42 -0700
- Subject: Re: [patch] Fix DW_AT_const_value using DW_FORM_string
- References: <alpine.LNX.2.00.0905111333270.25789@zhemvz.fhfr.qr> <20090511120439.GA12905@host0.dyn.jankratochvil.net> <20090513195222.GA23545@host0.dyn.jankratochvil.net> <4A0B2DD4.2060708@redhat.com> <Pine.LNX.4.64.0905132259510.29566@wotan.suse.de> <4A0C3789.4080709@redhat.com> <Pine.LNX.4.64.0905141735150.29566@wotan.suse.de> <4A0C8129.2080100@redhat.com> <alpine.LNX.2.00.0905152143250.25789@zhemvz.fhfr.qr> <20090515210810.GA19455@host0.dyn.jankratochvil.net>
Thanks for looking at this.
> 2009-05-15 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> Fix parsing DW_AT_const_value using DW_FORM_string.
> * dwarf2read.c (dwarf2_const_value <DW_FORM_string>): New.
>
> gdb/testsuite/
> 2009-05-15 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> * gdb.dwarf2/dw2-strp.exp (p a_string2, ptype a_string2): New.
> * gdb.dwarf2/dw2-strp.S (a_string2): New.
Looks all good to me; please go ahead and commit.
--
Joel