This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfa][testsuite] Consolidade Python test functions in lib/gdb.exp.


El lun, 18-05-2009 a las 21:11 +0300, Eli Zaretskii escribiÃ:
> > gdb/testsuite/
> > 	* lib/python-support.exp: New file.
> > 	* lib/gdb.exp: Load python-support.exp.
> > 	* gdb.python/python-cmd.exp: Use Python test functions from
> > 	lib/python-support.exp instead of defining its own functions.
> > 	* gdb.python/python-frame.exp: Likewise.
> > 	* gdb.python/python-function.exp: Likewise.
> > 	* gdb.python/python-value.exp: Likewise.
> > 	* gdb.python/python.exp: Likewise.
> 
> Btw, is it possible to rename these files so as to avoid file-name
> clashes on 8+3 filesystems, as in python-frame.exp and
> python-function.exp (and the need to tweak config/djgpp/fnchange.lst
> accordingly)?  The name `gdb.python' already tells that this is about
> Python, so there should be no need for the "python-" name prefix for
> the files therein, right?

Yes, I agree with you. I used this naming scheme just to follow the
naming scheme used in the gdb/python directory. I don't actually like
the filenames there, for the same reason. I just use it to comply with a
request when the first Python patch was accepted. I don't dislike it
enough to argue and ask for changes though.

What do you think? Is it just fine to have the testcase files named
differently from the source files? There's not a strict 1:1 mapping
between them, but it's close.
-- 
[]'s
Thiago Jung Bauermann
IBM Linux Technology Center


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]