This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [Prec/RFA] fix build error of prec in cygwin
On Mon, May 18, 2009 at 23:35, Christopher Faylor
<cgf-use-the-mailinglist-please@sourceware.org> wrote:
> On Mon, May 18, 2009 at 04:43:36PM +0800, Hui Zhu wrote:
>>On Mon, May 11, 2009 at 07:51, Christopher Faylor wrote:
>>> So wouldn't that indicate that your format specifier is wrong and should
>>> be "%u" rather than "%d"? ?Coercion is something that should be avoided
>>> unless it is absolutely necessary.
>>>
>>
>>I changed it.
>
> It looks like this diff is against your previous version rather than CVS
> so it is confusing. ?But, it still seems like you're still coercing
> using (int)len but now you're using %u. ?So, it looks like you've just
> swapped the problem.
No, it based on cvs-head. Are you really try?
With out (int) it will get:
../../src/gdb/linux-record.c: In function `record_linux_system_call':
../../src/gdb/linux-record.c:1787: warning: unsigned int format, long
int arg (arg 4)
make: *** [linux-record.o] Error 1
In Cygwin.
Thanks,
Hui