This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Eliminate quadratic slow-down on number of soilibs (part 2).
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Paul Pluzhnikov <ppluzhnikov at google dot com>
- Cc: gdb-patches at sourceware dot org, Tom Tromey <tromey at redhat dot com>
- Date: Tue, 12 May 2009 11:10:57 +0200
- Subject: Re: [patch] Eliminate quadratic slow-down on number of soilibs (part 2).
- References: <20090501221639.4FF8A19C4E1@localhost>
> 2009-05-01 Paul Pluzhnikov <ppluzhnikov@google.com>
>
> * objc-lang.c (objc_objfile_data): New variable.
> (find_methods): Skip objfiles without Obj-C methods.
> (_initialize_objc_lang): New function.
Looks good to me. If I may, would you mind adding a comment explaining
*why* you count the number of symbols? I think it can help understanding
the added code a little bit faster...
/* If we haven't done so for this objfile yet, count the number
of objc methods that this objfile defines and save it as a private
objfile data. That way, if have already determined that this
objfile provides no objc methods, we can skip it entirely. */
I wonder how well support for ObjC works. It looks like this file hasn't
really be worked on for a long time... Did you have an objc compiler in
your path when you did the testing, by any chance?
--
Joel