This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Process record and replay checked in to main trunk
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Hui Zhu <teawater at gmail dot com>
- Cc: gdb-patches at sourceware dot org, msnyder at vmware dot com
- Date: Fri, 01 May 2009 12:26:55 +0300
- Subject: Re: Process record and replay checked in to main trunk
- References: <daef60380904300059g191dfe0bu7773ee01f35892bf@mail.gmail.com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
May I suggest the following changes in some of the doc strings related
to this feature? In addition to rewording, it also reformats the way
the strings are presented, so that it is easy to spot when we exceed
the width of the screen and need to break long lines.
2009-05-01 Eli Zaretskii <eliz@gnu.org>
* record.c (_initialize_record): Reformat and clarify doc strings
for stop-at-limit and insn-number-max.
Index: gdb/record.c
===================================================================
RCS file: /cvs/src/src/gdb/record.c,v
retrieving revision 1.2
diff -u -r1.2 record.c
--- gdb/record.c 30 Apr 2009 02:58:37 -0000 1.2
+++ gdb/record.c 1 May 2009 09:24:01 -0000
@@ -1259,28 +1259,21 @@
/* Record instructions number limit command. */
add_setshow_boolean_cmd ("stop-at-limit", no_class,
- &record_stop_at_limit,
- _("Set whether record/replay stop when "
- "record/replay buffer becomes full."),
- _("Show whether record/replay stop when "
- "record/replay buffer becomes full."),
- _("Enable is default value.\n"
- "When enabled, if the record/replay buffer "
- "becomes full,\n"
- "ask user what to do.\n"
- "When disabled, if the record/replay buffer "
- "becomes full,\n"
- "delete it and start new recording."),
+ &record_stop_at_limit, _("\
+Set whether record/replay stops when record/replay buffer becomes full."), _("\
+Show whether record/replay stops when record/replay buffer becomes full."), _("\
+Default is ON.\n\
+When ON, if the record/replay buffer becomes full, ask user what to do.\n\
+When OFF, if the record/replay buffer becomes full,\n\
+delete the oldest recorded instruction to make room for each new one."),
NULL, NULL,
&set_record_cmdlist, &show_record_cmdlist);
add_setshow_zinteger_cmd ("insn-number-max", no_class,
&record_insn_max_num,
_("Set record/replay buffer limit."),
- _("Show record/replay buffer limit."),
- _("Set the maximum number of instructions to be "
- "stored in the\n"
- "record/replay buffer. "
- "Zero means unlimited (default 200000)."),
+ _("Show record/replay buffer limit."), _("\
+Set the maximum number of instructions to be stored in the\n\
+record/replay buffer. Zero means unlimited. Default is 200000."),
set_record_insn_max_num,
NULL, &set_record_cmdlist, &show_record_cmdlist);
add_cmd ("insn-number", class_obscure, show_record_insn_number,