This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Fix a buglet in elfread.c

From: Frank Middleton <f dot middleton at apogeect dot com>
To: Joel Brobecker <brobecker at adacore dot com>
Cc: Paul Pluzhnikov <ppluzhnikov at google dot com>, gdb-patches at sourceware dot org
Date: Thu, 30 Apr 2009 20:07:05 -0400
Subject: Re: [patch] Fix a buglet in elfread.c
References: <20090430164806.7DED819C4E1@localhost> <20090430215422.GE10734@adacore.com>

On 04/30/09 17:54, Joel Brobecker wrote:

2009-04-30 Paul Pluzhnikov<ppluzhnikov@google.com>
	* elfread.c (elf_symtab_read): Don't assume .data and .rodata
	are present.

Looks good to me. Please go ahead and apply.

I tested this patch on sparc-solaris 2.8 with -gstabs+, since this
seems to be related to stabs. I don't think we can really test
this part of the code with a GCC compiler, but perhaps it's is
still exercised throught the loading of some of the Solaris shared
libraries.  We did our best, and we had 2 pairs of eyes looking at it,
so it should be fine.


FWIW this wasn't a problem until at or after Solaris 10 (SunOS 5.10),
so your testing would presumably show that this patch didn't break
anything. I've been using the patched version all day on SunOS 5.11
(snv103) and it seems to be working perfectly, so it doesn't seem
like anything got broken and it certainly seems fixed. Thanks again!

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]