This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [RFC] Change OK: to ARI: for ARI rule ignore


Thanks to Joel and Tom for their answers.

  I checked the source patch in.

The only thing is that the 6.8 branch will 
have new warnings because the OK patterns
are not disregarded anymore, but
I don't think that we will ever release a 6.8.1 anyhow!

  My initial idea for gdb_ari.sh turned out to be
wrong (I got more regression)
The final diff for gdb_ari.sh looks like this:

$ cvs diff gdb_ari.sh
Index: gdb_ari.sh
===================================================================
RCS file: /cvs/gdbadmin/ss/gdb_ari.sh,v
retrieving revision 1.89
diff -r1.89 gdb_ari.sh
149a150,152
>     if (ARI_OK == bug) {
>       return
>     }
208,209c211,225
< # Skip OK lines
< /\/\* OK \*\// || /\/\* OK: / || /\/\* ARI: / { next; }
---
> # Skip ARI lines
>
> BEGIN {
>     ARI_OK = ""
> }
>
> /\/\* ARI:[[:space:]]*(.*)[[:space:]]*\*\// {
>     ARI_OK = gensub(/^.*\/\*
ARI:[[:space:]]*(.*[^[:space:]])[[:space:]]*\*\/.*$/, "\\1", 1, $0)
>     # print "ARI line found \"" $0 "\""
>     # print "ARI_OK \"" ARI_OK "\""
> }
> ! /\/\* ARI:[[:space:]]*(.*)[[:space:]]*\*\// {
>     ARI_OK = ""
> }
>

Is this OK?

Pierre



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]