This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: FYI: fix Solaris problem with auto host charset
- From: Tom Tromey <tromey at redhat dot com>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: gdb-patches at sourceware dot org
- Date: Sat, 18 Apr 2009 11:12:31 -0600
- Subject: Re: FYI: fix Solaris problem with auto host charset
- References: <m3prfa7sd5.fsf@fleche.redhat.com> <83y6tyihzh.fsf@gnu.org>
- Reply-to: Tom Tromey <tromey at redhat dot com>
>>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:
Eli> Btw, why is the code assuming that nl_langinfo always returns a
Eli> meaningful result?
Oversight.
Eli> Also, I don't quite get the reason why nl_langinfo is not called in
Eli> the PHONY_ICONV case. It seems we blindly assume the native charset
Eli> is Latin-1 in that case, but perhaps nl_langinfo, if it exists, will
Eli> give a better guess?
In the PHONY_ICONV case we have no way to convert between character
sets. I think this only affects u'' and U''; so it really a matter of
which failure you want in this situation.
If you want to change this, it is fine by me.
Tom