This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

fix warning when qAttach isn't supported by the remote side


Oooops.  I'm working with a stub that doesn't support the new qAttached
packet, and quickly found out that there's a silly bug that ends
up in an ugly "Remote failure reply" every time we connect...

 Sending packet: $qAttached#8f...Packet received:
 Packet qAttached (query-attached) is NOT supported
 warning: Remote failure reply:
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

I'll check in the below in a bit to address this.

-- 
Pedro Alves

2009-04-16  Pedro Alves  <pedro@codesourcery.com>

	* remote.c (remote_query_attached): Fix pasto in packet_ok result
	checking.

---
 gdb/remote.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: src/gdb/remote.c
===================================================================
--- src.orig/gdb/remote.c	2009-04-01 18:42:03.000000000 +0100
+++ src/gdb/remote.c	2009-04-16 20:25:01.000000000 +0100
@@ -1139,7 +1139,7 @@ remote_query_attached (int pid)
   getpkt (&rs->buf, &rs->buf_size, 0);
 
   switch (packet_ok (rs->buf,
-		     &remote_protocol_packets[PACKET_qAttached]) == PACKET_OK)
+		     &remote_protocol_packets[PACKET_qAttached]))
     {
     case PACKET_OK:
       if (strcmp (rs->buf, "1") == 0)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]