This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] gdbadmin/ss/ update var_boolean rule

I updated the var_boolean rule:
 - three appearances are needed,
1 for declaration in gdb/command.h
and two in gdb/cli/cli-decode.c

I also removed appearances of type
  case var_boolean:

For the gdb/cli/cli-decode.c
fix, it took me a while to understand
   fix("var_boolean", "gdb/cli/cli-decode.c", 2)
did not work.
  It appears that the fail function strips
all but the last directory part to create shortname,
which is then used to compare to skipped[bug,shortname] 
thus I had to use
   fix("var_boolean", "cli/cli-decode.c", 2)
which works fine.

committed with the following log:

        * Update var_boolean rule.

Pierre Muller
Pascal language support maintainer for GDB

RCS file: /cvs/gdbadmin/ss/,v
retrieving revision 1.83
diff -u -r1.83
---  6 Apr 2009 21:54:24 -0000       1.83
+++  14 Apr 2009 20:45:36 -0000
@@ -1493,9 +1493,14 @@
 BEGIN { doc["var_boolean"] = "\
 Replace var_boolean with add_setshow_boolean_cmd"
     category["var_boolean"] = ari_obsolete
+    fix("var_boolean", "gdb/command.h", 1)
+    # fix only uses the last directory level
+    fix("var_boolean", "cli/cli-decode.c", 2)
 /(^|[^_[:alnum:]])var_boolean([^_[:alnum:]]|$)/ {
-    fail("var_boolean")
+    if ($0 !~ /(^|[^_[:alnum:]])case *var_boolean:/) {
+       fail("var_boolean")
+    }


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]