This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [1/3] broken -thread-info output in non-stop mode, suppress_stop_observer
- From: Vladimir Prus <vladimir at codesourcery dot com>
- To: Pedro Alves <pedro at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 17 Mar 2009 10:26:29 +0300
- Subject: Re: [1/3] broken -thread-info output in non-stop mode, suppress_stop_observer
- References: <200903170621.02808.pedro@codesourcery.com>
On Tuesday 17 March 2009 09:21:02 Pedro Alves wrote:
> This patch removes the suppress_stop_observer global. As indicated
> in the comments I'm removing, this was problematic for non-stop
> mode.
>
> To fix the broken -thread-info output mentioned here:
>
> http://sourceware.org/ml/gdb-patches/2009-03/msg00236.html
>
> ... I wanted to add a thread_info->in_infcall flag to use in
> the 3rd patch in the series. That meant I needed to get rid of
> the suppress_resume_observer global, which then brings
> us to this.
>
> Vladimir, et al, how does this look?
I did not look very carefully at details of conditions, but the
general idea looks solid. One detail is the new command you
add in infrun.c -- can it explicitly write down *why* we need to
suppress *stopped at this point, when doing finish?
Thanks,
Volodya