This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Correct `gcc -D' macros get ignored (PR 9873)
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 9 Mar 2009 11:41:38 -0700
- Subject: Re: [patch] Correct `gcc -D' macros get ignored (PR 9873)
- References: <20090219214540.GA32244@host0.dyn.jankratochvil.net> <20090228071514.GA25299@adacore.com> <20090228100225.GA15788@host0.dyn.jankratochvil.net> <20090303005430.GL26056@adacore.com> <20090309005707.GB29150@host0.dyn.jankratochvil.net>
> 2009-03-09 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> PR gdb/9873:
> * dwarf2read.c (dwarf_decode_macros): New variable `at_commandline'.
> Move the variable `macinfo_type' out of the loop. Create a new
> processing pass before the current one to pre-create `current_file'.
> New complaint on misplaced zero/non-zero definitions/includes.
> Skip first DW_MACINFO_start_file with `at_commandline' set.
This is OK, with one tiny typo (and I'm probably the one responsible
for it).
> Sure I find your text better although its first line does not follow the GNU
> Coding Style directive `[...] please write complete sentences [...]'.
> Used your text.
Are you refering to the "First pass:"? I think it's OK.
> OK although it was catching both inconsistencies so it has to be written as
>
> if ((line == 0 && !at_commandline) || (line != 0 && at_commandline))
Right!
> + associated to base file.
^^^ "the" base file...
Cheers,
--
Joel