This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Fix a crash when displaying variables from shared library.

From: Paul Pluzhnikov <ppluzhnikov at google dot com>
To: Joel Brobecker <brobecker at adacore dot com>
Cc: tromey at redhat dot com, Pedro Alves <pedro at codesourcery dot com>, gdb-patches at sourceware dot org
Date: Thu, 5 Mar 2009 19:18:42 -0800
Subject: Re: [patch] Fix a crash when displaying variables from shared library.
References: <20090205030257.8A6073A6B7A@localhost> <8ac60eac0902181458g39dfbce9k63c3329528b0aad5@mail.gmail.com> <20090223010759.GA30997@adacore.com> <8ac60eac0902231012lb42bcb1q8b8cf19ad2ac192@mail.gmail.com> <8ac60eac0903021830w363783ear7d4c8fc1177d6448@mail.gmail.com> <m37i36jeop.fsf@fleche.redhat.com> <8ac60eac0903041124s1aafb562u225f268c4d1511dd@mail.gmail.com> <20090305200415.GC3744@adacore.com> <8ac60eac0903051546r1eaffc89tf1f35b21e6dc1b40@mail.gmail.com> <8ac60eac0903051906r5d41990bwcaccdfb4accef562@mail.gmail.com>

On Thu, Mar 5, 2009 at 7:06 PM, Paul Pluzhnikov <ppluzhnikov@google.com> wrote:

> I am not sure whether:
> A) bp_shlib_event type breakpoints should also be shlib_disable'd, or
> B) disable_breakpoints_in_unloaded_shlib() should only warn about
>   bp_breakpoint and bp_hardware_breakpoint type, or
> C) the call to "solib_address (block->startaddr)" should be replaced with
>   something like "solib_contains_p (solib, block->startaddr)" (which would
>   then work independently of the so_list_head).

Or (D) remove (currently useless) block->startaddr checks, and rely solely on
symbol->section->objfile == solib->objfile check.

Thanks,
-- 
Paul Pluzhnikov

References:
- Re: [patch] Fix a crash when displaying variables from shared library.
  - From: Paul Pluzhnikov
- Re: [patch] Fix a crash when displaying variables from shared library.
  - From: Tom Tromey
- Re: [patch] Fix a crash when displaying variables from shared library.
  - From: Paul Pluzhnikov
- Re: [patch] Fix a crash when displaying variables from shared library.
  - From: Joel Brobecker
- Re: [patch] Fix a crash when displaying variables from shared library.
  - From: Paul Pluzhnikov
- Re: [patch] Fix a crash when displaying variables from shared library.
  - From: Paul Pluzhnikov

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]