This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/4] catch syscall -- try 4 -- Architecture-independent part
- From: Pedro Alves <pedro at codesourcery dot com>
- To: gdb-patches at sourceware dot org
- Cc: Sérgio Durigan Júnior <sergiodj at linux dot vnet dot ibm dot com>, teawater <teawater at gmail dot com>
- Date: Mon, 26 Jan 2009 00:53:06 +0000
- Subject: Re: [PATCH 1/4] catch syscall -- try 4 -- Architecture-independent part
- References: <1232929831.26873.22.camel@miki>
One quick comment before bedtime :-),
On Monday 26 January 2009 00:30:31, Sérgio Durigan Júnior wrote:
> + ?printf_filtered (_("\nCatchpoint %d ("), b->number);
> +
> + ?if (last.kind == TARGET_WAITKIND_SYSCALL_ENTRY)
> + ? ?printf_filtered (_("call to "));
> + ?else
> + ? ?printf_filtered (_("returned from "));
> +
> + ?printf_filtered (_("syscall "));
> +
> + ?if (s.name == NULL)
> + ? ?printf_filtered (_("%d"), b->syscall_number);
> + ?else
> + ? ?printf_filtered (_("'%s'"), s.name);
> + printf_filtered (_("), "));
> +
Could you please combine this into full sentences, please? It
will be better for translation, and probably clearer to read. Say:
struct cleanup *old_chain;
char *syscall_id;
if (s.name == NULL)
syscall_id = xstrprintf ("%d", b->syscall_number);
else
syscall_id = xstrprintf ("'%s'", s.name);
old_chain = make_cleanup (xfree, syscall_id);
if (last.kind == TARGET_WAITKIND_SYSCALL_ENTRY)
printf_filtered (_("\nCatchpoint %d (call to syscall %s), "),
syscall_id);
else
printf_filtered (_("\nCatchpoint %d (returned from %s), "),
syscall_id);
do_cleanups (old_chain);
--
Pedro Alves