This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] fix build breakage on arm-none-eabi
On Thu, Jan 08, 2009 at 11:11:42AM -0800, Stan Shebs wrote:
> Nathan Froyd wrote:
> >The patch below fixes compilation. sim/common/callback.c calls exit, so
> >I figured it was fair to make gdb_os_error call exit as well.
> >
> This is good, thanks! (I ran into it in a checkout yesterday too.)
Thanks. Pedro alerted me to the presence of ATTR_NORETURN; this is what
I committed instead.
-Nathan
Index: remote-sim.c
===================================================================
RCS file: /cvs/src/src/gdb/remote-sim.c,v
retrieving revision 1.81
diff -u -r1.81 remote-sim.c
--- remote-sim.c 3 Jan 2009 05:57:53 -0000 1.81
+++ remote-sim.c 8 Jan 2009 19:17:17 -0000
@@ -70,7 +70,7 @@
static void gdb_os_evprintf_filtered (host_callback *, const char *, va_list);
-static void gdb_os_error (host_callback *, const char *, ...);
+static void gdb_os_error (host_callback *, const char *, ...) ATTR_NORETURN;
static void gdbsim_fetch_register (struct regcache *regcache, int regno);
@@ -273,6 +273,7 @@
verror (format, args);
va_end (args);
}
+ exit (1);
}
int