This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: RFA: fix macro expansion bug
On Thursday 11 December 2008 23:25:48, Tom Tromey wrote:
> >>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:
>
> Pedro> Though, I'm having a bit of trouble convincing myself that the logic to
> Pedro> handle 'pp-number e|E|p|P|. sign' below is 100% sane.
> [...]
> Pedro> It seems macro_is_identifier_nondigit will always eat any of "eEpP",
> Pedro> thus, say, when parsing "1e-" only "1e" will be identified as a pp
> Pedro> number, leaving "+" in the stream. Is this right?
>
> Yeah. Also, "." should not appear in the strchr argument.
>
> Here's a new patch. I'll regression-test it. I don't expect
> problems. Ok if it passes?
Certainly. Thanks.
> >> + "expands to: siginfo. fields.fault.si_addr" \
>
> Pedro> Just curious, as it's just a visual annoyance: do you know where
> Pedro> this space comes from? Do we store the definition with the space for
> Pedro> some reason? We don't get that extra space if the define came
> Pedro> from the code, instead of from a 'macro define'.
>
> Yes, it is a bug in "macro define".
> I'll fix shortly.
>
Thanks!
--
Pedro Alves