This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Simplify breakpoint.c function parameters

From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
To: Vladimir Prus <vladimir at codesourcery dot com>, Joel Brobecker <brobecker at adacore dot com>
Cc: gdb-patches at sourceware dot org
Date: Mon, 8 Dec 2008 14:30:51 +0100
Subject: Re: [patch] Simplify breakpoint.c function parameters
References: <20081207222253.GA6749@host0.dyn.jankratochvil.net> <20081208110536.GB3823@adacore.com> <20081207222253.GA6749@host0.dyn.jankratochvil.net> <ghiilu$rud$1@ger.gmane.org>

On Mon, 08 Dec 2008 08:34:22 +0100, Vladimir Prus wrote:
> FWIW, this sounds reasonable and safe to me.

On Mon, 08 Dec 2008 12:05:36 +0100, Joel Brobecker wrote:
> After careful review, this looks right to me.

Thanks both for the review, checked it in.


> I'm wondering if it would make sense to get rid of the loc_type field
> and compute it on the fly through a function...

I do not disagree.


Regards,
Jan

References:
- [patch] Simplify breakpoint.c function parameters
  - From: Jan Kratochvil
- Re: [patch] Simplify breakpoint.c function parameters
  - From: Joel Brobecker
- Re: [patch] Simplify breakpoint.c function parameters
  - From: Vladimir Prus

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]