This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: remove warnings in sim/arm


Doug Evans wrote:
On Mon, Nov 24, 2008 at 1:11 PM, Joel Sherrill
<joel.sherrill@oarcorp.com> wrote:
Hi,

a couple of files in arm/sim had warnings because
they did not include <string.h>.  Simple patch
to include <string.h>

Ok to commit?

2008-11-24 Joel Sherrill <joel.sherrill@oarcorp.com>

* arminit.c, iwmmxt.c: Include <string.h> to
eliminate warning.

Other sims check HAVE_STRING_H, as does gdb (and STDC_HEADERS), but
there are already files in sim/arm that don't (and at some point we
should no longer need to), so this patch is fine by me.
Thanks.  I looked for HAVE_STRING_H in other sim/arm files
and since it wasn't there, I didn't use it.  Do you want another
patch to add HAVE_STRING_H to all the files?

I have committed this one.

--joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]