This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Fix gdbserver vRun parsing again
- From: Pedro Alves <pedro at codesourcery dot com>
- To: Daniel Jacobowitz <drow at false dot org>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 24 Nov 2008 17:59:36 +0000
- Subject: Re: [patch] Fix gdbserver vRun parsing again
- References: <20081124173135.GA9091@caradoc.them.org>
On Monday 24 November 2008 17:31:35, Daniel Jacobowitz wrote:
> As part of closing PR 2474, I took another look at Pedro's fix last
> month to vRun. I approved it at the time but now I can see that he
> and I were both a little confused about the documented semantics :-(
> With Pedro's patch, "target extended-remote", "run one", "run two"
> will never run the program with argv[1] == "two". We're always
> supposed to use the new argv. "vRun;" means "old program, no args";
> "vRun;;XXXX" means "old program, decoded arg XXXX".
>
Oh, very sorry about that. I should have sticked to fixing
the crash. :-(
> This patch seems to do the right thing; Pedro, want to take a look at
> this obviously tricky code before I change it?
I tried it out, and it does do the right thing, and I
also confirmed the original crash isn't reintroduced.
Thanks.
--
Pedro Alves