This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: fix address in call to val_print


>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

>> Ok, I will hold off on this patch until I can make a test case.

Joel> No no, don't, that's not what I meant - the patch looked good so let's
Joel> put it in now. If you had a testcase, then let's have it now rather than
Joel> later, even if it already passed before you applied the patch. If not,
Joel> oh well. Sorry, I realize I'm not always clear when I express myself.

Sorry, I was too brief.

My reasoning was that I do not know whether it is easy to make a test
case or not.  I would have to look into it.

IMO, if it is possible, it makes the most sense to do this before
committing the patch.  Otherwise, I will have to undo the patch to
test it, which is a pain (not so bad in this instance, but in
general).

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]