This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] fix thinko in sym info
On Wed, Nov 19, 2008 at 3:02 PM, Paul Pluzhnikov <ppluzhnikov@google.com> wrote:
> On Wed, Nov 19, 2008 at 2:52 PM, Doug Evans <dje@google.com> wrote:
>
>> asm-source.exp is now failing because it doesn't expect the offset
>> to be printed if its zero.
>> One could update the testcase, but the old behaviour is more user-friendly.
>
> Hmm, why didn't I notice this failure ...
> It's UNTESTED for me both before and after. I'll investigate why.
>
>> The outstanding question is, of course, whether
>> "%s + %u", msym_name, offset
>> needs i18n. This patch assumes it doesn't.
>
> From: http://sourceware.org/ml/gdb-patches/2008-11/msg00378.html
>
> In addition, translating each part without seeing the whole
> sentence is very difficult.
Sure, but this part of the sentence seems self-contained enough that
the translation could consider it as a unit. I could be wrong of
course, but will pedantic translation correctness in this particular
case be worth it.
> I didn't want to add 8 more clauses to this if statement.
No disagreement there.