This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 4/4] catch syscall -- try 3 -- Build system, documentation and testcase
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Sérgio Durigan Júnior <sergiodj at linux dot vnet dot ibm dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 19 Nov 2008 00:37:31 +0200
- Subject: Re: [PATCH 4/4] catch syscall -- try 3 -- Build system, documentation and testcase
- References: <1226987134.5454.37.camel@miki> <uskpols50.fsf@gnu.org> <1227044596.5454.47.camel@miki>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: =?ISO-8859-1?Q?S=E9rgio?= Durigan =?ISO-8859-1?Q?J=FAnior?= <sergiodj@linux.vnet.ibm.com>
> Cc: gdb-patches@sourceware.org
> Date: Tue, 18 Nov 2008 19:43:15 -0200
>
> > > +Catchpoint 1 (calling syscall 'close'), 0xffffe424 in __kernel_vsyscall ()
> >
> > I'd prefer
> >
> > Catchpoint 1 (call to syscall 'close')
>
> Right, but can I ask you why? :-)
Because "call to" goes better with "return from". "calling" would go
with "returning".
> > > +(gdb) catch syscall 252
> > > +Catchpoint 1 (syscalls 'exit_group')
> >
> > The translation to a mnemonic name will only happen if the XML file
> > does know about the syscall, right? What if it doesn't?
>
> You mean that I should mention what would happen in this case? I think
> that's already mentioned, am I wrong?
You did, but since the text says that 252 is for the case of unknown
mnemonics, it would be better if the example reflected that case as
well, don't you think?