This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 4/4] catch syscall -- try 3 -- Build system, documentation and testcase
- From: Sérgio Durigan Júnior <sergiodj at linux dot vnet dot ibm dot com>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 18 Nov 2008 19:43:15 -0200
- Subject: Re: [PATCH 4/4] catch syscall -- try 3 -- Build system, documentation and testcase
- References: <1226987134.5454.37.camel@miki> <uskpols50.fsf@gnu.org>
Hi Eli,
On Tue, 2008-11-18 at 22:02 +0200, Eli Zaretskii wrote:
> > From: =?ISO-8859-1?Q?S=E9rgio?= Durigan =?ISO-8859-1?Q?J=FAnior?= <sergiodj@linux.vnet.ibm.com>
> > Date: Tue, 18 Nov 2008 03:45:34 -0200
> >
> > +if @var{GDBN} does not fully support your system's list of system
> ^^^^^^^^^^
> @value{GDBN}
Sorry, I'll have that fixed.
>
> > +(gdb) catch syscall
> > +Catchpoint 1 (syscall)
>
> That's a strange wording. Wouldn't it be better to say
>
> Catchpoint 1 (any syscall)
>
> ?
Yeah, I think you're right.
> Also, please use (@value{GDBP}) (P, not N) instead of a literal (gdb),
> when you show a prompt.
OK.
> > +Catchpoint 1 (calling syscall 'close'), 0xffffe424 in __kernel_vsyscall ()
>
> I'd prefer
>
> Catchpoint 1 (call to syscall 'close')
Right, but can I ask you why? :-)
> > +(gdb) catch syscall chroot
> > +Catchpoint 1 (syscalls 'chroot')
>
> "syscalls 'chroot'" (in plural) or "syscall 'chroot'" (single)?
Yes, it's single. I'll fix. :-)
> > +(gdb) catch syscall 252
> > +Catchpoint 1 (syscalls 'exit_group')
>
> The translation to a mnemonic name will only happen if the XML file
> does know about the syscall, right? What if it doesn't?
You mean that I should mention what would happen in this case? I think
that's already mentioned, am I wrong?
> Otherwise, the doco patch is approved.
Thank you very much.
--
Sérgio Durigan Júnior
Linux on Power Toolchain - Software Engineer
Linux Technology Center - LTC
IBM Brazil