This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 4/4] catch syscall -- try 3 -- Build system, documentation and testcase

> From: =?ISO-8859-1?Q?S=E9rgio?= Durigan =?ISO-8859-1?Q?J=FAnior?= <>
> Date: Tue, 18 Nov 2008 03:45:34 -0200
> +if @var{GDBN} does not fully support your system's list of system

> +(gdb) catch syscall
> +Catchpoint 1 (syscall)

That's a strange wording.  Wouldn't it be better to say

  Catchpoint 1 (any syscall)


Also, please use (@value{GDBP}) (P, not N) instead of a literal (gdb),
when you show a prompt.

> +Catchpoint 1 (calling syscall 'close'), 0xffffe424 in __kernel_vsyscall ()

I'd prefer

   Catchpoint 1 (call to syscall 'close')

> +(gdb) catch syscall chroot
> +Catchpoint 1 (syscalls 'chroot')

"syscalls 'chroot'" (in plural) or "syscall 'chroot'" (single)?

> +(gdb) catch syscall 252
> +Catchpoint 1 (syscalls 'exit_group')

The translation to a mnemonic name will only happen if the XML file
does know about the syscall, right?  What if it doesn't?

Otherwise, the doco patch is approved.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]