This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] fix some punctuation and capitalization errors in infcall.c


If they were comments, they'd be obvious.

Since they change visible output, have you run the testsuites
to see if they affect any tests?

Doug Evans wrote:
While hacking in infcall.c I found a few nits.
At least I think these are nits based on what I found elsewhere in the tree.

Ok to check in?

2008-11-15 Doug Evans <dje@google.com>

	* infcall.c (call_function_by_hand): Fix punctuation and capitalization
	on error messages.

	* gdb.mi/mi-syn-frame.exp: Update expected output.
	* gdb.mi/mi2-syn-frame.exp: Update expected output.

Index: infcall.c
===================================================================
RCS file: /cvs/src/src/gdb/infcall.c,v
retrieving revision 1.105
diff -u -p -u -p -r1.105 infcall.c
--- infcall.c 12 Nov 2008 00:39:28 -0000 1.105
+++ infcall.c 15 Nov 2008 22:43:10 -0000
@@ -339,7 +339,7 @@ call_function_by_hand (struct value *fun
gdbarch = get_frame_arch (frame);
if (!gdbarch_push_dummy_call_p (gdbarch))
- error (_("This target does not support function calls"));
+ error (_("This target does not support function calls."));
/* Create a cleanup chain that contains the retbuf (buffer
containing the register values). This chain is create BEFORE the
@@ -529,7 +529,7 @@ call_function_by_hand (struct value *fun
}
if (nargs < TYPE_NFIELDS (ftype))
- error (_("too few arguments in function call"));
+ error (_("Too few arguments in function call."));
{
int i;
@@ -754,7 +754,7 @@ The program being debugged exited while error (_("\
The program being debugged was signaled while in a function called from GDB.\n\
GDB has restored the context to what it was before the call.\n\
-To change this behavior use \"set unwindonsignal off\"\n\
+To change this behavior use \"set unwindonsignal off\".\n\
Evaluation of the expression containing the function (%s) will be abandoned."),
name);
}
@@ -774,7 +774,7 @@ Evaluation of the expression containing error (_("\
The program being debugged was signaled while in a function called from GDB.\n\
GDB remains in the frame where the signal was received.\n\
-To change this behavior use \"set unwindonsignal on\"\n\
+To change this behavior use \"set unwindonsignal on\".\n\
Evaluation of the expression containing the function (%s) will be abandoned."),
name);
}


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]