This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Darwin/x86 port (v3 of part 3: i386-darwin files)
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Tristan Gingold <gingold at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 14 Nov 2008 13:18:25 +0200
- Subject: Re: [RFA] Darwin/x86 port (v3 of part 3: i386-darwin files)
- References: <20081112125150.GA21514@ulanbator.act-europe.fr>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Wed, 12 Nov 2008 13:51:50 +0100
> From: Tristan Gingold <gingold@adacore.com>
>
> i386-darwin-tdep.h:
Thanks.
> /* Offsets into the struct i386_thread_state where we'll find the saved regs. */
> /* From <mach/i386/thread_status.h and i386-tdep.h */
^
A closing bracket `>' is missing here.
> /* Offsets into the struct x86_thread_state64 where we'll find the saved regs. */
> /* From <mach/i386/thread_status.h and amd64-tdep.h */
^
And here.
> if (ret != KERN_SUCCESS)
> {
> printf ("Error calling thread_get_state for GP registers for thread 0x%ulx", current_thread);
> MACH_CHECK_ERROR (ret);
printf? is that right? didn't you mean printf_filtered or
printf_unfiltered?
In any case, please enclose all user messages in _(), for when we will
support l10n.
(There are several similar instances elsewhere in this patch.)
> if (! fetched)
> {
> warning ("unknown register %d", regno);
Same here: please use _().