This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Move -nx from GDBFLAGS to INTERNAL_GDBFLAGS in testsuite
- From: Doug Evans <dje at google dot com>
- To: Joel Brobecker <brobecker at adacore dot com>, Pedro Alves <pedro at codesourcery dot com>, gdb-patches at sourceware dot org
- Date: Fri, 7 Nov 2008 14:42:41 -0800
- Subject: Re: [RFA] Move -nx from GDBFLAGS to INTERNAL_GDBFLAGS in testsuite
- References: <20081021190500.BB7251C7954@localhost> <200810271252.35628.pedro@codesourcery.com> <20081030030147.GB3635@adacore.com>
On Wed, Oct 29, 2008 at 7:01 PM, Joel Brobecker <brobecker@adacore.com> wrote:
>> I like the idea of this patch. I tend to use "set GDBFLAGS foo" in
>> my boardfiles myself.
>>
>> What do others think of it?
>
> Seems like a good idea to me as well. That's consistent with what
> we do in the Makefile, I believe.
>
>> > +# INTERNAL_GDBFLAGS contains flags that the testsuite requires.
>> > +# ??? Perhaps -nw should go here too. Dunno.
>>
>> Personally, I'd decide/chose one, and remove this comment. If
>> you leave it in, we're doomed to stare and be annoyed by
>> it forever. :-)
>
> I would put the -nw in INTERNAL_GDBCFLAGS as well. Except maybe for
> the doing some TUI-specific testing, I don't see us testing the
> debugger in graphical mode.
Any other comments? Can I check it in after moving -nw into INTERNAL_GDBCFLAGS?