This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 4/4] 'catch syscall' feature -- Build system, documentation and testcase


> From: =?ISO-8859-1?Q?S=E9rgio?= Durigan =?ISO-8859-1?Q?J=FAnior?= <sergiodj@linux.vnet.ibm.com>
> Date: Tue, 04 Nov 2008 02:31:28 -0200
> 
> This last part modifies the build system (in order to implement the
> GDB's datadir), adds the documentation and the testcase for the new
> feature.

Thanks.

However,

> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index 261d1c7..3641fff 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -3635,6 +3635,12 @@ A failed Ada assertion.
>  A call to @code{exec}.  This is currently only available for HP-UX
>  and @sc{gnu}/Linux.
>  
> +@item syscall
> +@itemx syscall @var{syscall name}
> +@cindex break on call to/return from a system call
> +A call to/return from a @code{syscall} -- similar to the @code{strace}
> +utility.

...this is not really a user documentation.  Please describe the
feature instead of sending the reader to look for external
documentation of an unrelated utility, which, btw, is available only
on some versions of Unix, but not on others.

At the very least, we should explain what is @var{syscall name}.  An
example of usage and typical GDB output get bonus points.

Thanks.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]