This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 4/4] 'catch syscall' feature -- Build system, documentation and testcase


On Tuesday 04 November 2008 20:32:35, Sérgio Durigan Júnior wrote:
> I just haven't spelled out because those files (configure, config.in)
> are not included in the patch. Should I mention them anyway?

Yep.  It helps us make sure the right pieces will be
regenerated; and help the ones that want to try the patch to know
which files they need to regenerate, and you'll have to spell them out
anyway at commit time.  :-)

(personally, if regenerated changes are small-ish, I don't mind if
they're included in the patch, since it makes it easier to
try the patches out (bandwidth is cheaper nowadays), and confirm the
submitter is using the correct autotools version.  But, that's not
established practice, and I'm a newbie here  :-).  In fact, not
including them is recommended in gdb/CONTRIBUTE.)

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]