This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 4/4] 'catch syscall' feature -- Build system, documentation and testcase
- From: Tom Tromey <tromey at redhat dot com>
- To: SÃrgio Durigan JÃnior <sergiodj at linux dot vnet dot ibm dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 04 Nov 2008 09:32:43 -0700
- Subject: Re: [PATCH 4/4] 'catch syscall' feature -- Build system, documentation and testcase
- References: <1225773088.24532.56.camel@miki>
- Reply-to: tromey at redhat dot com
>>>>> "SÃrgio" == SÃrgio Durigan JÃnior <sergiodj@linux.vnet.ibm.com> writes:
SÃrgio> This last part modifies the build system (in order to
SÃrgio> implement the GDB's datadir), adds the documentation and the
SÃrgio> testcase for the new feature.
Nice.
SÃrgio> +xml-syscall-copy:
SÃrgio> + list='$(XML_SYSCALLS_FILES)' ; \
SÃrgio> + for file in $$list ; do \
Two nits here.
First, if you build with builddir!=srcdir, you need to mkdir
XML_SYSCALLS_DIR here.
Second, I think it would be nice to detect the case where
builddir==srcdir and not copy in that case.
SÃrgio> +xml-syscall-install:
SÃrgio> + $(SHELL) $(srcdir)/../mkinstalldirs \
SÃrgio> + $(DESTDIR)$(GDB_DATADIR_PATH)/$(XML_SYSCALLS_DIR) ; \
Using DESTDIR is nice attention to detail :-)
SÃrgio> +# Also, the "install" target installs the syscalls' XML files in the system.
SÃrgio> +install: all install-only xml-syscall-install
I think install-only should depend on xml-syscall-install.
I believe the intent here is that "make install-only" will install
everything without rebuilding.
SÃrgio> +AC_ARG_WITH(gdb-datadir,
SÃrgio> +[ --with-gdb-datadir=path Look for global separate data files in this path [DATADIR/gdb]],
It is preferable, IMO, to use AS_HELP_STRING here.
There are some examples of this in gdb's configure.ac.
SÃrgio> +AC_CONFIG_SUBDIRS(doc testsuite syscalls)
You don't want this. There is no syscalls directory, and even if
there was, I would argue that it should not have its own configure
script.
SÃrgio> +@item syscall
SÃrgio> +@itemx syscall @var{syscall name}
SÃrgio> +@cindex break on call to/return from a system call
SÃrgio> +A call to/return from a @code{syscall} -- similar to the @code{strace}
SÃrgio> +utility.
This needs a minor update now that "catch syscall" can take multiple
arguments.
I didn't read the implementation patch in detail... if it parses
numeric syscalls, then that should be mentioned here.
Finally, instead of "call to/return from", how about "call to or
return from"? This is more grammatical and not much longer :-)
Tom