This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Make attach_command exception-safe
- From: Vladimir Prus <vladimir at codesourcery dot com>
- To: Daniel Jacobowitz <drow at false dot org>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Tue, 4 Nov 2008 00:08:05 +0300
- Subject: Re: [RFA] Make attach_command exception-safe
- References: <200808291110.43091.vladimir@codesourcery.com> <20080829142418.GA15675@caradoc.them.org>
On Friday 29 August 2008 18:24:18 Daniel Jacobowitz wrote:
> On Fri, Aug 29, 2008 at 07:10:42AM +0000, Vladimir Prus wrote:
> >
> > When attach_command executes, it might disable stdin. It further might
> > throw, and does not enable stdin in that case. For CLI case, top-level
> > event loop will catch the exception and enable stdin. For MI case, MI
> > interpreter catches the exception in order to print the error message,
> > and of course it has no idea about any stdin disabling.
> >
> > This patch makes attach_command exception-safe, enabling stdin on
> > throw.
> >
> > OK?
>
> OK.
I've now checked this in.
Thanks,
Volodya