This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Make procfs.c build warning free
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Pedro Alves <pedro at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 29 Sep 2008 17:25:26 -0700
- Subject: Re: Make procfs.c build warning free
- References: <200809090326.13826.pedro@codesourcery.com>
> 2008-09-09 Pedro Alves <pedro@codesourcery.com>
>
> Make it compile without warnings.
>
> * procfs.c (dead_procinfo): Pass a constant string as format to
> error.
> (procfs_address_to_host_pointer): Add cast to gdb_type *.
> (procfs_find_LDT_entry): Adjust format string to long int
> ptid.tid.
> (procfs_xfer_partial): Adjust prototype. Add gdb_byte* cast.
> (procfs_xfer_memory): Adjust prototype.
> (info_mappings_callback, info_proc_mappings): Adjust to not pass a
> variable as printf_filtered format.
> (procfs_make_note_section): Change type of auxv local to gdb_byte.
The changes look good to me (not that you really need my approval anymore
:-). I didn't do a general audit, but I'm sure we can fix any warning as
soon as one comes up.
I wish I had the time to clean this up a little bit and implement it
properly...
PS: I wonder which OSes use procfs through ioctl calls? Perhaps we could
already greatly simplify the file if we could get rid of that part
of the support (assuming this is for systems that are no longer
in use).
--
Joel