This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Fix for failing gdb.base/mips_pro.exp under gcc-4.3.1


On Thu, Sep 4, 2008 at 4:58 PM, Joel Brobecker <brobecker@adacore.com> wrote:
> (sorry about the delay - it looks like everyone was very very busy
> this summer)
>
>> I could not find *why* optimization is necessary for that test case,
>> so don't know if disabling inlining is the correct fix :(
>
> Like Michael said, we have to assume the obvious, which is that they
> wanted to test unwinding of optimized code.
>
>> 2008-02-12  Paul Pluzhnikov  <ppluzhnikov@google.com>

Hmm, that should have been 2008-08-22 ...

>>
>>       *gdb.base/mips_pro.exp: compile with gcc -fno-inline,
>>       lest gcc-4.3.1 optimizes the whole thing away.
>
> With that in mind, your patch makes sense. We want optimized code, but
> not that much optimization :).

So ok to commit?

Thanks,
-- 
Paul Pluzhnikov


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]