This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH-ppc 0/5] Add feature description for new VSX register set
- From: Thiago Jung Bauermann <bauerman at br dot ibm dot com>
- To: luisgpm at linux dot vnet dot ibm dot com
- Cc: gdb-patches at sourceware dot org
- Date: Sat, 02 Aug 2008 00:26:26 -0300
- Subject: Re: [PATCH-ppc 0/5] Add feature description for new VSX register set
- References: <1217016935.29012.74.camel@gargoyle>
On Fri, 2008-07-25 at 17:15 -0300, Luis Machado wrote:
> This specific patch adds 32 new 64-bit wide "vsxh" (doubleword 1 of
> VSR0~VSR31) registers and addresses the required dependencies in the
> makefiles.
Reviewed and found only very minor things.
> * features/res6000/powerpc-vsx32.c: New file (generated).
> * features/res6000/powerpc-vsx32l.c: New file (generated).
> * features/res6000/powerpc-vsx64.c: New file (generated).
> * features/res6000/powerpc-vsx64l.c: New file (generated).
> * features/Makefile: Updated with new descriptions.
> * regformats/rs6000/powerpc-vsx32l.dat: New file (generated).
> * regformats/rs6000/powerpc-vsx64l.dat: New file (generated).
Please don't include generated files in the patch. It just adds noise
and makes the review more difficult.
> * Makefile: Updated with new descriptions.
It's Makefile.in, actually.
> Index: gdb/features/rs6000/powerpc-vsx32l.xml
> ===================================================================
> --- /dev/null 1970-01-01 00:00:00.000000000 +0000
> +++ gdb/features/rs6000/powerpc-vsx32l.xml 2008-07-25 08:24:19.000000000 -0700
> @@ -0,0 +1,20 @@
> +<?xml version="1.0"?>
> +<!-- Copyright (C) 2008 Free Software Foundation, Inc.
> +
> + Copying and distribution of this file, with or without modification,
> + are permitted in any medium without royalty provided the copyright
> + notice and this notice are preserved. -->
> +
> +<!-- PowerPC UISA - a PPC processor as viewed by user-level code. A UISA-only
> + view of the PowerPC. Includes Linux-only special "registers" and AltiVec
> + vector registers. -->
... and VSX vector registers.
> Index: gdb/features/rs6000/powerpc-vsx64.xml
> ===================================================================
> --- /dev/null 1970-01-01 00:00:00.000000000 +0000
> +++ gdb/features/rs6000/powerpc-vsx64.xml 2008-07-25 08:24:19.000000000 -0700
> @@ -0,0 +1,18 @@
> +<?xml version="1.0"?>
> +<!-- Copyright (C) 2008 Free Software Foundation, Inc.
> +
> + Copying and distribution of this file, with or without modification,
> + are permitted in any medium without royalty provided the copyright
> + notice and this notice are preserved. -->
> +
> +<!-- PowerPC UISA - a PPC processor as viewed by user-level code. A UISA-only
> + view of the PowerPC. Includes AltiVec vector registers. -->
ditto
> Index: gdb/features/rs6000/powerpc-vsx64l.xml
> ===================================================================
> --- /dev/null 1970-01-01 00:00:00.000000000 +0000
> +++ gdb/features/rs6000/powerpc-vsx64l.xml 2008-07-25 08:24:19.000000000 -0700
> @@ -0,0 +1,20 @@
> +<?xml version="1.0"?>
> +<!-- Copyright (C) 2008 Free Software Foundation, Inc.
> +
> + Copying and distribution of this file, with or without modification,
> + are permitted in any medium without royalty provided the copyright
> + notice and this notice are preserved. -->
> +
> +<!-- PowerPC UISA - a PPC processor as viewed by user-level code. A UISA-only
> + view of the PowerPC. Includes Linux-only special "registers" and AltiVec
> + vector registers. -->
Same here.
--
[]'s
Thiago Jung Bauermann
IBM Linux Technology Center