This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[commit] Fix intermittent MI testsuite failures
- From: Daniel Jacobowitz <drow at false dot org>
- To: gdb-patches at sourceware dot org
- Date: Sun, 27 Jul 2008 17:00:09 -0400
- Subject: [commit] Fix intermittent MI testsuite failures
I started seeing UNTESTED's in my logs yesterday. I don't know why
this never triggered before, but I can see the problem.
There are several checks for the prompt in default_mi_gdb_start.
First we look for $mi_gdb_prompt$, in other words a string ending with
"(gdb) \r\n". But then we look for a string ending in
"$gdb_prompt $", in other words "(gdb) ". So if output pauses between
the "(gdb) " and the "\r\n", we can falsely detect a non-MI prompt.
This check isn't useful; if MI was disabled, GDB shouldn't even start
up with -i=mi. So I've removed it, and the intermittent UNTESTEDs are
gone.
Tested on mips-linux and committed.
--
Daniel Jacobowitz
CodeSourcery
2008-07-27 Daniel Jacobowitz <dan@codesourcery.com>
* lib/mi-support.exp (default_mi_gdb_start): Remove check for
non-MI prompt.
---
gdb/testsuite/lib/mi-support.exp | 5 -----
1 file changed, 5 deletions(-)
Index: gdb-only/gdb/testsuite/lib/mi-support.exp
===================================================================
--- gdb-only.orig/gdb/testsuite/lib/mi-support.exp 2008-07-26 20:24:30.000000000 -0400
+++ gdb-only/gdb/testsuite/lib/mi-support.exp 2008-07-26 20:24:31.000000000 -0400
@@ -169,11 +169,6 @@ proc default_mi_gdb_start { args } {
}
verbose "GDB initialized."
}
- -re ".*$gdb_prompt $" {
- untested "Skip mi tests (got non-mi prompt)."
- remote_close host;
- return -1;
- }
-re ".*unrecognized option.*for a complete list of options." {
untested "Skip mi tests (not compiled with mi support)."
remote_close host;