This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH][gdbserver] Check for sys/dir.h and sys.user.h in configuration.
- From: Michael Snyder <msnyder at specifix dot com>
- To: Doug Kwan (éæå) <dougkwan at google dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 22 Jul 2008 20:48:30 -0700
- Subject: Re: [PATCH][gdbserver] Check for sys/dir.h and sys.user.h in configuration.
- References: <498552560807221759w1ade0ec2jd63c12475ddb5217@mail.gmail.com>
On Tue, 2008-07-22 at 17:59 -0700, Doug Kwan (éæå) wrote:
> Hi,
>
> gdbserver does not compile for the Android operating system
> because of missing headers sys/user.h and sys/dir.h and a declaration
> of errno inside a function. The following patch fixes these problem.
> Does it look okay? If so, could someone approve and commit it for me?
> Thanks.
>
> -Doug
>
> 2008-07-22 Doug Kwan <dougkwan@google.com>
>
> * configure.ac: Check for sys/dir.h and sys.user.h.
> * config.in configure: Regenerate.
> * linux-low.c: Include <sys/dir.h> if HAVE_SYS_DIR_H is defined.
> Include <sys/user.h> if HAVE_SYS_USER_H is defined.
> (linux_write_memory): Declare errno if STDC_HEADERS is not defined.
I'm surprised by some of the diffs in the generated configure
script -- wonder if you used a different version of autoconf
or something?
Otherwise looks pretty OK.
I don't know enough to say whether STDC_HEADERS is the right
ifdef for the errno change in linux_write_memory.