Re: RFA: Patch: annotations -vs- deprecated hooks

[Joel Brobecker <brobecker at adacore dot com>]

Nick: Would you like to do some testing before this patch gets checked in?
(note that this is dependent on Tom's previous "observers" patch).

Hi Tom,

> There are still a couple of hooks called by the annotations code that
> are used by gdbtk.  This setup seems weird to me.  I guess these ought
> to be replaced by observers.

I agree - I didn't check why gdbtk is dependent on annotation hooks,
but we should also ask them about it, and try to remove these hooks.

> b/gdb/ChangeLog:
> 2008-07-13  Tom Tromey  <tromey@redhat.com>
> 
> 	* annotate.h (deprecated_annotate_starting_hook): Remove.
> 	(deprecated_annotate_stopped_hook): Remove.
> 	(deprecated_annotate_exited_hook): Remove.
> 	* Makefile.in (annotate.o): Depend on observer_h.
> 	* top.c (deprecated_delete_breakpoint_hook): Remove.
> 	(deprecated_create_breakpoint_hook): Likewise.
> 	(deprecated_modify_breakpoint_hook): Likewise.
> 	* interps.c (clear_interpreter_hooks): Update for removed hooks.
> 	* breakpoint.c (mention): Don't call removed hook.
> 	(delete_breakpoint): Likewise.
> 	(disable_breakpoint): Likewise.
> 	(do_enable_breakpoint): Likewise.
> 	* annotate.c: Include observer.h.
> 	(breakpoint_changed): Change type of argument.
> 	(_initialize_annotate): Register observers.
> 	(deprecated_annotate_starting_hook): Remove.
> 	(deprecated_annotate_stopped_hook): Remove.
> 	(deprecated_annotate_exited_hook): Remove.
> 	(annotate_starting): Update for hook removal.
> 	(annotate_stopped): Likewise.
> 	(annotate_exited): Likewise.
> 	* defs.h (deprecated_delete_breakpoint_hook): Remove.
> 	(deprecated_create_breakpoint_hook): Likewise.
> 	(deprecated_modify_breakpoint_hook): Likewise.

This looks good to me. We have to wait a little bit for Vladimir's
comments before you can commit the observers patch, so that should give
Nick a little bit of time to do any testing he might need (although
ideally running the testsuite should be enough).

-- 
Joel