This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [MI non-stop 01/11] Report thread state in -thread-info output.
- From: Vladimir Prus <vladimir at codesourcery dot com>
- To: gdb-patches at sources dot redhat dot com
- Date: Sun, 13 Jul 2008 09:38:50 +0400
- Subject: Re: [MI non-stop 01/11] Report thread state in -thread-info output.
- References: <200806282034.58776.vladimir@codesourcery.com> <20080711134159.GC2651@caradoc.them.org>
Daniel Jacobowitz wrote:
> On Sat, Jun 28, 2008 at 08:34:58PM +0400, Vladimir Prus wrote:
>> + if (tp->state_ == THREAD_EXITED)
>> + state = "exited";
>
> /* This field is internal to thread.c. Never access it directly,
> use is_running instead. */
> int state_;
>
> Aren't there accessors you can use here?
Well, we talked with Pedro about this, I believe. The issue now is that is_xxx
function take ptid, and do lookup. The right solution would be to have
is_xxx_ptid functions taking ptid and is_xxx functions taking thread_info*.
Pedro, does this approach seem OK for you, in the end?
Meanwhile, I've checked in the patch as posted.
- Volodya