This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [MI non-stop 04/11] Implement --thread and --frame.
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Vladimir Prus <vladimir at codesourcery dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Sat, 28 Jun 2008 20:22:01 +0300
- Subject: Re: [MI non-stop 04/11] Implement --thread and --frame.
- References: <200806282044.14246.vladimir@codesourcery.com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: Vladimir Prus <vladimir@codesourcery.com>
> Date: Sat, 28 Jun 2008 20:44:14 +0400
>
>
> + if (parse->frame != -1 && !parse->thread == -1)
> + error ("Cannot specify --frame without --thread");
Why is this error message not in _(), while all the rest are?
Btw, do we at all want error messages issued by MI commands
translated? MI commands are invoked by a program, so error messages
we generate should be understandable by a program, which probably
means they should not be translated.
> + if (strncmp (chp, "--thread", 8) == 0)
Please, let's not use literal constants in this context, let's use
sizeof instead.
> + parse->frame = strtol (chp, &chp, 10);
Do we really want to disallow non-decimal numbers here? What about
hex frame numbers?