This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [non-stop] 05/10 Refactor a bit infrun.c
A Wednesday 25 June 2008 20:11:59, Daniel Jacobowitz wrote:
> On Sun, Jun 15, 2008 at 10:04:43PM +0100, Pedro Alves wrote:
> > @@ -1491,13 +1510,16 @@ wait_for_inferior (int treat_exec_as_sig
> > void
> > fetch_inferior_event (void *client_data)
> > {
> > + struct execution_control_state ecss = ecss;
>
> Please don't use this - IIRC it's a GCC extension to shut up
> uninitialized variable warnings. If there are warnings without the
> initializer, just memset it.
Oh, shame on me, have no idea how that slipped there. :-( All the
vars in execution_control_state are always cleared in handle_inferior_event,
but it's just safer to memset it, or '= {0}' it, as you say.
Thanks a lot for the review.
--
Pedro Alves