This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: RFA: fix two field name completion bugs
- From: Daniel Jacobowitz <drow at false dot org>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Mon, 9 Jun 2008 14:45:45 -0400
- Subject: Re: RFA: fix two field name completion bugs
- References: <m33ann93c7.fsf@fleche.redhat.com>
On Sun, Jun 08, 2008 at 12:41:28PM -0600, Tom Tromey wrote:
> ChangeLog:
> 2008-06-08 Tom Tromey <tromey@redhat.com>
>
> * completer.c (complete_line): Don't special-case
> expression_completer.
> (expression_completer): Only pass last word to
> location_completer.
> * c-exp.y (yylex): Check 'token', not 'operator'.
This part is OK.
> +send_gdb "p values\[0\] . a\t"
> +sleep 3
> +gdb_expect {
I know there's other tests in completion.exp that do this but are the
sleeps really necessary? Anywhere that we sleep, the testsuite
becomes timing sensitive - not to mention slow.
--
Daniel Jacobowitz
CodeSourcery