This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Do not add partial_symbol again and again to the list
- From: Daniel Jacobowitz <drow at false dot org>
- To: Aleksandar Ristovski <aristovski at qnx dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 5 Jun 2008 14:16:39 -0400
- Subject: Re: [patch] Do not add partial_symbol again and again to the list
- References: <20080211223056.GA3833@caradoc.them.org> <47B0CF8A.6080306@qnx.com> <20080211225314.GA5832@caradoc.them.org> <47B27EB1.6030606@qnx.com> <20080503205413.GA22704@caradoc.them.org> <481F58ED.5070207@qnx.com> <20080506141754.GA17275@caradoc.them.org> <48209891.3000400@qnx.com> <20080506175636.GA31803@caradoc.them.org> <4820B072.8030906@qnx.com>
On Tue, May 06, 2008 at 03:24:34PM -0400, Aleksandar Ristovski wrote:
> Daniel Jacobowitz wrote:
>>
>> I think we should finish up this patch, and then proceed from there.
>>
>> Should we use this optimization for all global psymtabs? If so, then
>> we ought to do it in common code so that all the other symbol readers,
>> like stabs, benefit.
>>
>
> Ok, here is simplified, but with broader consequences patch.
>
> The patch now affects all readers that use add_psymbol_to_list by not
> allowing duplicate partial symbols in the global psymbol list (for a given
> objfile).
>
> Tested on linux dwarf2 format, no regression. I did
> not test other debug formats.
This is OK if you'll rename bcache_added to deprecated_bcache_added,
as we discussed before. I think it'll work fine.
> +void *
> +bcache_added (const void *addr, int length, struct bcache *bcache,
> + int *added)
Wrong indentation there?
--
Daniel Jacobowitz
CodeSourcery