This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch/mdebug] symbol symtab not set on Tru64


> > As a result, we end up with SEGVs or failed assertions when trying
> > to access this field because it was NULL. Fixed thusly.
> 
> Is this a regression due to my recent SYMBOL_SYMTAB cleanup patch?

Your patch might have made the problem more visible, not sure, but
the issue was introduced much earlier than this (I think early 2007),
when this new field was added. I noticed it a couple of weeks ago,
before you checked your cleanup patch in.

> > 2008-05-26  Joel Brobecker  <brobecker@adacore.com>
> > 
> >         Set the symtab field of symbols read from ECOFF debugging entries.
> >         * mdebugread.c (add_symbol): Add new parameter symtab.
> >         (parse_symbol): Update calls to add_symbol throughout.
> 
> In any case, this looks good to me ...

Thanks for double-checking it! I will check it in shortly.

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]